feat: Add delegate filter param's to account_tx RPC by PeterChen13579 · Pull Request #2827 · XRPLF/clio

PeterChen13579 · 2025-12-01T18:59:25Z

This PR adds the ability to filter account_tx results based on transaction delegation. This is useful for scenarios where one account (the delegatee) signs and submits a transaction on behalf of another account (the delegator).

New Request Parameter:

"delegate": {
     "delegate_filter": "actor" or "authorizor",
     "counter_party": "account_address" 
}

Example: If User A submits a transaction to C on behalf of B:
User B (The account holder) can query with delegate_filter: "actor" to find transactions signed by others (like User A).
User A (The signer) can query with delegate_filter: "authorizer" to find transactions they signed for others (like User B).
The counter_party field can be used in either case to filter by a specific valid address

codecov · 2025-12-01T19:12:20Z

Codecov Report

❌ Patch coverage is 97.70115% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/rpc/common/Validators.cpp	95.00%	0 Missing and 1 partial ⚠️
...rc/rpc/filters/impl/DelegateTransactionsFilter.cpp	95.65%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

…79/clio into fix-delegate-filter

PeterChen13579 · 2026-04-08T17:44:29Z

Will wait for Rippled PR to be merged first before merging this one 🫡

Copilot

Pull request overview

Adds delegation-aware filtering to the account_tx RPC so callers can request only transactions where the queried account participated via sfDelegate (either as the authorizer/owner or as the actor/signer), optionally constrained to a specific counterparty.

Changes:

Introduces delegate request parameter validation/parsing (delegate_filter + optional counter_party) and threads it into AccountTxHandler.
Implements DelegateTransactionFilter to include/exclude transactions based on sfDelegate semantics and annotates results with authorizer/actor for matched delegated txns.
Adds unit test coverage for parsing, validation, filtering behavior, and handler integration.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/unit/rpc/RPCHelpersTests.cpp	Adds unit tests for `parseDelegateType` / `parseDelegateFilter`.
tests/unit/rpc/handlers/AccountTxTests.cpp	Adds parameter-validation and handler behavior tests for `delegate` filtering.
tests/unit/rpc/filters/impl/DelegateTransactionsFilterTests.cpp	New unit tests for the delegate transaction filter logic.
tests/unit/CMakeLists.txt	Registers the new filter test file in the unit test build.
tests/common/util/TestObject.hpp	Declares `createDelegateBlob` test helper.
tests/common/util/TestObject.cpp	Implements `createDelegateBlob` helper to produce delegated tx blobs.
tests/common/util/MockBackendTestFixture.hpp	Removes an unused include.
src/rpc/RPCHelpers.hpp	Declares delegate parsing helpers.
src/rpc/RPCHelpers.cpp	Implements delegate parsing helpers.
src/rpc/handlers/AccountTx.hpp	Extends handler input/spec to accept `delegate` and adds validator.
src/rpc/handlers/AccountTx.cpp	Applies delegate filtering in the account_tx loop and adds `authorizer`/`actor` output fields (non-binary path).
src/rpc/filters/TransactionFilter.hpp	Introduces a filter interface and `FilterResult` struct.
src/rpc/filters/impl/DelegateTransactionsFilter.hpp	Declares `DelegateTransactionFilter`.
src/rpc/filters/impl/DelegateTransactionsFilter.cpp	Implements delegation-based transaction matching.
src/rpc/common/Validators.hpp	Declares `delegateValidator`.
src/rpc/common/Validators.cpp	Implements `delegate` parameter validation (required `delegate_filter`, optional valid-account `counter_party`).
src/rpc/common/Types.hpp	Adds `DelegateFilter` request type.
src/rpc/CMakeLists.txt	Adds the new filter implementation to the rpc target sources.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

godexsoft

Leaving some small things. Overall PR looks good!
One more thing that you can try to do is to find and remove/simplify comments that are too verbose or unnecessary - i have seen some on the way through this PR.

godexsoft · 2026-07-30T16:22:41Z

@@ -0,0 +1,85 @@
+//------------------------------------------------------------------------------


We no longer add these banners

godexsoft · 2026-07-30T16:23:46Z

@@ -0,0 +1,54 @@
+//------------------------------------------------------------------------------


godexsoft · 2026-07-30T16:24:14Z

@@ -0,0 +1,54 @@
+//------------------------------------------------------------------------------


godexsoft · 2026-07-30T16:31:42Z

            boost::json::value_to<std::string>(jsonObject.at("tx_type"));
    }

+    if (jsonObject.contains(JS(delegate))) {


nit: Probably can do without the curlies here?

godexsoft · 2026-07-30T16:32:54Z

@@ -0,0 +1,212 @@
+//------------------------------------------------------------------------------


This is also not needed

feat: add delegate filter param's to account_tx RPC

7a58d95

PeterChen13579 changed the title ~~feat: add delegate filter param's to account_tx RPC~~ feat: Add delegate filter param's to account_tx RPC Dec 1, 2025

PeterChen13579 added 2 commits December 1, 2025 16:57

fix doxygen

141aa14

remove try catch

18bcdf3

godexsoft reviewed Dec 2, 2025

View reviewed changes

Comment thread src/data/cassandra/CassandraBackendFamily.hpp Outdated

godexsoft reviewed Dec 2, 2025

View reviewed changes

Comment thread src/rpc/RPCHelpers.cpp Outdated

godexsoft reviewed Dec 2, 2025

View reviewed changes

Comment thread src/rpc/common/Types.hpp Outdated

PeterChen13579 and others added 5 commits December 5, 2025 13:27

decouple filtering

55f5961

fix doxygen

300219a

Merge branch 'develop' into fix-delegate-filter

eb83ca3

Merge remote-tracking branch 'upstream/develop' into fix-delegate-filter

7ee435e

Merge branch 'fix-delegate-filter' of https://github.com/PeterChen135…

d8ffa5d

…79/clio into fix-delegate-filter

PeterChen13579 and others added 9 commits April 8, 2026 14:10

merge with latest develop

efe8a49

Merge branch 'develop' into fix-delegate-filter

fbdef94

Merge remote-tracking branch 'upstream' into fix-delegate-filter

902668e

fix the rest

595e1b9

fix magic strings

5553eee

fix comments to match new JS field and add test

2f4987e

fix clang tidy

909573d

fix clang tidy now..

541c0a0

f clang tidy

bfc6675

PeterChen13579 requested a review from godexsoft July 23, 2026 21:22

mathbunnyru requested a review from Copilot July 28, 2026 15:14

Copilot started reviewing on behalf of mathbunnyru July 28, 2026 15:14 View session

Copilot AI reviewed Jul 28, 2026

View reviewed changes

Comment thread src/rpc/filters/impl/DelegateTransactionsFilter.cpp Outdated

PeterChen13579 and others added 2 commits July 29, 2026 11:14

fix comment

d5846f6

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'develop' into fix-delegate-filter

42c4721

godexsoft requested changes Jul 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add delegate filter param's to account_tx RPC - #2827

feat: Add delegate filter param's to account_tx RPC#2827
PeterChen13579 wants to merge 19 commits into
XRPLF:developfrom
PeterChen13579:fix-delegate-filter

PeterChen13579 commented Dec 1, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PeterChen13579 commented Apr 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

godexsoft left a comment

Uh oh!

godexsoft Jul 30, 2026

Uh oh!

godexsoft Jul 30, 2026

Uh oh!

godexsoft Jul 30, 2026

Uh oh!

godexsoft Jul 30, 2026

Uh oh!

godexsoft Jul 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,85 @@
		//------------------------------------------------------------------------------

		@@ -0,0 +1,54 @@
		//------------------------------------------------------------------------------

		@@ -0,0 +1,212 @@
		//------------------------------------------------------------------------------

Uh oh!

Conversation

PeterChen13579 commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PeterChen13579 commented Apr 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

godexsoft left a comment

Choose a reason for hiding this comment

Uh oh!

godexsoft Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

godexsoft Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

godexsoft Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

godexsoft Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

godexsoft Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PeterChen13579 commented Dec 1, 2025 •

edited

Loading

codecov Bot commented Dec 1, 2025 •

edited

Loading